Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Include image tag in built image #1125

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes https://github.com/WordPress/openverse-infrastructure/issues/332 by @AetherUnbound

Description

This PR changes the API and API nginx images to include the image tag as a part of the built docker images, so it can be referenced appropriately once the service is deployed without having to alter the ECS task definition every time.

The logic I've added should use the github SHA as the SEMANTIC_VERSION for all pushes to main, but use the ref name (e.g. tag version like "v2.5.10") for all releases.

Testing Instructions

Very hard to test GitHub actions, this is based off of similar work on the frontend so I'm hoping it works!

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 4, 2023 01:34
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1125

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 4, 2023
@AetherUnbound AetherUnbound merged commit c386329 into main Feb 7, 2023
@AetherUnbound AetherUnbound deleted the feature/release-version branch February 7, 2023 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants